Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should caching include the API in the key? #384

Open
brianwgoldman opened this issue Apr 10, 2024 · 0 comments
Open

Should caching include the API in the key? #384

brianwgoldman opened this issue Apr 10, 2024 · 0 comments

Comments

@brianwgoldman
Copy link
Contributor

Imagine you have two APIs with exactly the same structure, but different underlying behavior. Maybe something like a "V1" and "V2" where the inputs are the same, but V2 fixes some flaw. In our current way of caching, we would accidentally treat responses to V1 as valid responses to V2. This is because the cache key is the json representation of the native request, and at least some SUTs (AKA Together) don't include the request URL in the request.

It seems pretty unlikely that two APIs would have identical input structure but we should expect them to return different behavior, so this feels like a low priority issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant