Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup time with plugins is large #371

Open
wpietri opened this issue Apr 4, 2024 · 1 comment
Open

Startup time with plugins is large #371

wpietri opened this issue Apr 4, 2024 · 1 comment

Comments

@wpietri
Copy link
Contributor

wpietri commented Apr 4, 2024

No description provided.

@brianwgoldman
Copy link
Contributor

I did a really dumb timing thing to see which module might be at fault:

start = datetime.now()
importlib.import_module(module_name)
diff = datetime.now() - start

Even when shuffling the order of the loop, huggingface_client is almost always the slowest by about twice second place, which is discrim_eval, which is twice third place. These two both have large unique dependencies (transformers and [sklearn, statsmodels], respectively) that seems like plausible culprits.

There does seem to be some caching, as poetry install followed by poetry install --extras all_plugins makes the first run very slow (6 seconds) vs subsequent calls (2 seconds).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants