Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Include docker image digest to mlcube id for medperf test #529

Open
VukW opened this issue Feb 13, 2024 · 0 comments
Open

[FEATURE] Include docker image digest to mlcube id for medperf test #529

VukW opened this issue Feb 13, 2024 · 0 comments

Comments

@VukW
Copy link
Contributor

VukW commented Feb 13, 2024

During mlcube development user builds & runs image with the same tag a lot of times, after every change. Right now only mlcube/ folder hash is used for calculating temporary mlcube id; it includes image tag, but not image digest. It means, that if the image is updated & rebuilt, mlcube/ folder is not changed => model id is not changed => medperf behaves as it is running exactly the same model (in particular, not recalculating predictions). That goes silently and is not so obvious to the user.

I propose to add image digest during temporary mlcube id calculation, so updated image would be treated as a totally new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant