Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] A command to edit entities #344

Open
hasan7n opened this issue Dec 20, 2022 · 7 comments · May be fixed by #447
Open

[FEATURE] A command to edit entities #344

hasan7n opened this issue Dec 20, 2022 · 7 comments · May be fixed by #447

Comments

@hasan7n
Copy link
Contributor

hasan7n commented Dec 20, 2022

Add a command to edit entities (benchmarks, mlcubes, datasets). Example:
medperf mlcube edit --uid <uid> --key val

This is related to #44 where users should have the option to change their dataset's state to OPERATION.

@hasan7n hasan7n added the type: enhancement New feature or request label Dec 20, 2022
@hasan7n hasan7n added this to the 2023 Q1 milestone Dec 20, 2022
@hasan7n
Copy link
Contributor Author

hasan7n commented Dec 22, 2022

we can also have a command medperf <entity> deploy that edits state to "OPERATION"

@aristizabal95
Copy link
Contributor

This requires us to know what's the edition requirements, or entity state machine.

@aristizabal95
Copy link
Contributor

To discuss with @msheller

@hasan7n
Copy link
Contributor Author

hasan7n commented Feb 21, 2023

@hasan7n create an example using one of the entities

@hasan7n
Copy link
Contributor Author

hasan7n commented Mar 20, 2023

encapsulate "permissions" of editing (whether the requested field can be edited or not based on state). We can later modify these rules after we finalize the state machine.

Also, there no need for now to modify the server logic of handling editing

Focus on the client side logic

@aristizabal95 aristizabal95 linked a pull request May 31, 2023 that will close this issue
@aristizabal95
Copy link
Contributor

Open issues: Permissions for editing (how and when)
Checking for reproducibility of MLCubes after a change. Do output artifacts change? How to test this robustly?

@VukW
Copy link
Contributor

VukW commented May 21, 2024

So editing mode reproduces the same logic (and CLI command) as medperf mlcube submit with the following changes:

  • only for mlcube
  • only for development mode
  • uid field is required
  • other fields (as in submit commands) are optional

@VukW VukW assigned VukW and unassigned aristizabal95 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants