Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record_param_comms #51

Closed
XcodeRole opened this issue May 9, 2024 · 2 comments
Closed

record_param_comms #51

XcodeRole opened this issue May 9, 2024 · 2 comments
Labels
question Further information is requested

Comments

@XcodeRole
Copy link

I have encountered numerous 'record_param_comms' nodes in Chakra ET, which serve as child nodes to collective communication nodes. I presume that these functions are intended to log communication information, such as the communication domain for collective communications, the counterpart in point-to-point communications, the size of the communication volume, and other parameters. However, this is just my speculation, as I have not been able to find specific invocations of these functions within PyTorch. How is this information utilized within Chakra?

@XcodeRole XcodeRole added the question Further information is requested label May 9, 2024
@TaekyungHeo
Copy link
Contributor

As you have mentioned, record_param_comms functions as a parent node of a collective communication node. In Chakra, we do not use record_param_comms directly. We can easily identify communication nodes with record_param_comms. Moreover, it serves as a bridge between the actual collective communication node and its parent. We plan to remove record_param_comms from traces by updating the PyTorch profiler.

@srinivas212
Copy link
Contributor

Thanks for reporting this issue. We can review and accept a PR if you would like to add this feature to et converter.

@srinivas212 srinivas212 closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants