Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code styling through Ruff for linting #794

Open
Geeks-Sid opened this issue Feb 8, 2024 · 4 comments
Open

Some code styling through Ruff for linting #794

Geeks-Sid opened this issue Feb 8, 2024 · 4 comments

Comments

@Geeks-Sid
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently, there is a need for robust linting capabilities within the development environment to ensure code quality and adherence to coding standards. While existing linters offer some level of support, there is a gap in the availability of a comprehensive and efficient Python linter specifically designed for detecting potential security vulnerabilities and bugs.

Describe the solution you'd like
I propose integrating Ruff, a powerful Python linter, into the development environment. Ruff is specifically designed to analyze Python code for common security vulnerabilities, performance issues, and coding errors. By incorporating Ruff, developers can benefit from real-time feedback and suggestions to improve code quality and mitigate potential risks.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Integrating Ruff into the development environment would streamline the code review process and enhance the overall security posture of the GaNDLF. Additionally, Ruff's extensibility allows for customization to suit specific project requirements. A seamless integration of Ruff would empower developers to write more secure and reliable Python code.

@Geeks-Sid Geeks-Sid mentioned this issue Feb 8, 2024
10 tasks
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Stale issue message

@sarthakpati
Copy link
Collaborator

@Geeks-Sid - are you still planning to put this in?

@Geeks-Sid
Copy link
Collaborator Author

Sorry for the AWOL. I was not able to get it running without giving write permissions to a bot and therefore it becomes a glorified lint checker. Do you think we should allow bots write permissions to PR?

@sarthakpati
Copy link
Collaborator

Do you think we should allow bots write permissions to PR?

I don't think giving it write access is a good idea. However, having this as a check could potentially be of benefit. I am not very familiar with ruff, though. Can you give a high-level overview?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants