Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage for entrypoint variable of mlcube deployment #733

Open
sarthakpati opened this issue Nov 13, 2023 · 9 comments
Open

Test coverage for entrypoint variable of mlcube deployment #733

sarthakpati opened this issue Nov 13, 2023 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@sarthakpati
Copy link
Collaborator

sarthakpati commented Nov 13, 2023

@hasan7n: is there a way we can check this in the tests? We should perhaps discuss this in a separate issue, since this could perhaps be important.

Originally posted by @sarthakpati in #730 (comment)

@sarthakpati sarthakpati added the bug Something isn't working label Nov 13, 2023
Copy link
Contributor

Stale issue message

@sarthakpati
Copy link
Collaborator Author

Hey @hasan7n could you please take a look at this?

Copy link
Contributor

Stale issue message

@sarthakpati
Copy link
Collaborator Author

Hey @hasan7n can you take a crack at this?

@sarthakpati
Copy link
Collaborator Author

@VukW this should be fixed already with the new API branch, right?

@VukW
Copy link
Contributor

VukW commented May 20, 2024

@sarthakpati No, this part was never touched in new API branch. To tell truth I don't get quite well even after reading parent PR what exactly is the issue about? What do we need to check?

@sarthakpati
Copy link
Collaborator Author

Ah okay. It is basically that these lines are not getting covered by tests:

image

And since this is (IMO) an integral part of the deploy mechanism, I would assume a test would need to updated/added to cover it. I was trying to ask clarification from @hasan7n but he hasn't responded this thread, yet.

@VukW
Copy link
Contributor

VukW commented May 21, 2024

Are you talking about just a coverage of this line in deploy.py, or also about real check if container built with such an entrypoint would run properly?

@sarthakpati
Copy link
Collaborator Author

The coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants