Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Hugging Face Hub integration #728

Closed
wants to merge 2 commits into from
Closed

[WIP] Hugging Face Hub integration #728

wants to merge 2 commits into from

Conversation

katielink
Copy link

Fixes #727 [WIP]

Proposed Changes

  • Add model loading functionality from Hugging Face Hub
  • Add repo uploading functionality to Hugging Face Hub
  • Add model pushing functionality to Hugging Face Hub

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@katielink
Starting integration
8e4d1f2 
Signed-off-by: katielink <link.katie.e@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact support@mlcommons.org.
0 out of 1 committers have signed the MLCommons CLA.
❌ @katielink
You can retrigger this bot by commenting recheck in this Pull Request

@sarthakpati sarthakpati self-requested a review November 8, 2023 22:07
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2023 •
edited

Codecov Report

Attention: Patch coverage is 17.85714% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 95.11%. Comparing base (87af776) to head (a0a1a13).
Report is 528 commits behind head on master.

Files Patch % Lines
GANDLF/utils/modelio.py 17.85% 23 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
+ Coverage   94.71%   95.11%   +0.40%     
==========================================
  Files         117      117              
  Lines        8224     9909    +1685     
==========================================
+ Hits         7789     9425    +1636     
- Misses        435      484      +49
Flag Coverage Δ
unittests 95.11% <17.85%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

Stale pull request message

@github-actions github-actions bot closed this Jan 22, 2024
@sarthakpati sarthakpati reopened this Jan 26, 2024
@sarthakpati
Copy link
Collaborator

Shouldn't have been closed.

@github-actions GitHub Actions
Copy link
Contributor

Stale pull request message

@github-actions github-actions bot closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarthakpati sarthakpati Awaiting requested review from sarthakpati

Assignees
No one assigned
Labels
no-pr-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Hugging Face Hub integration
2 participants
@katielink @sarthakpati