Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better code profiling #639

Open
sarthakpati opened this issue May 5, 2023 · 6 comments
Open

Better code profiling #639

sarthakpati opened this issue May 5, 2023 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sarthakpati
Copy link
Collaborator

sarthakpati commented May 5, 2023 •
edited

Is your feature request related to a problem? Please describe.
Currently, all the code profiling is custom based on internal functions from psutil and/or pytorch. It would be great to have a more uniform solution.

Describe the solution you'd like
I found a few options:

  • Torch Profiler: Pros: extensive pytorch-specific debugging information; cons: requires changes to the training/inference apis of GaNDLF
  • Scalene: Pros: straightforward start and stop for pieces of code that are to be profiled; cons: generic hardware-level information
  • octoml: Pros: potential acceleration of prediction; cons: requires modification of model code, PyTorch-2.0 needed
  • DLProf: Pros: CLI-based; cons: doesn't seem to give pytorch-specific information
  • HolisticTraceAnalysis: Pros: tight integration with PyTorch; cons: very new library so might need to see how this develops

We should have a detailed discussion on any potential requirements and how we can evaluate these libraries.

Describe alternatives you've considered
N.A.

Additional context
N.A.
@sarthakpati sarthakpati added enhancement New feature or request help wanted Extra attention is needed labels May 5, 2023
@sarthakpati sarthakpati changed the title Better profiling Better code profiling May 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Stale issue message

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Stale issue message

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2023

Stale issue message

@github-actions GitHub Actions
Copy link
Contributor

Stale issue message

@github-actions GitHub Actions
Copy link
Contributor

Stale issue message

@github-actions GitHub Actions
Copy link
Contributor

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sarthakpati