From ec4f7306fb4a6bcc5daa4d97488c13d7620b2b39 Mon Sep 17 00:00:00 2001 From: Matthias Richter Date: Wed, 6 Mar 2024 21:57:34 +0100 Subject: [PATCH] Temporarily disabled exposing the Dask diagnostic dashboard (#872) Temporarily disabled exposing the Dask diagnostic dashboard port to the docker setup. Executing docker containers after each other using docker compose, leads sometimes to the case that the port is already in use. We should come up with a solution if we want to use the dask dashboard again. Fix: #870 --------- Co-authored-by: Robbe Sneyders --- src/fondant/pipeline/compiler.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/fondant/pipeline/compiler.py b/src/fondant/pipeline/compiler.py index b667988a..53fd8ad6 100644 --- a/src/fondant/pipeline/compiler.py +++ b/src/fondant/pipeline/compiler.py @@ -27,7 +27,9 @@ logger = logging.getLogger(__name__) -DASK_DIAGNOSTIC_DASHBOARD_PORT = 8787 +# export DASK_DIAGNOSTICS_PORT="" to get a dynamic port assigned +DASK_DIAGNOSTICS_PORT = os.environ.get("DASK_DIAGNOSTICS_PORT", ":8787") + KubeflowCommandArguments = t.List[t.Union[str, t.Dict[str, str]]] @@ -261,10 +263,7 @@ def _generate_spec( if extra_volumes: volumes.extend(extra_volumes) - ports: t.List[t.Union[str, dict]] = [] - ports.append( - f"{DASK_DIAGNOSTIC_DASHBOARD_PORT}:{DASK_DIAGNOSTIC_DASHBOARD_PORT}", - ) + ports = [f"8787{DASK_DIAGNOSTICS_PORT}"] services[component_id] = { "entrypoint": entrypoint,