Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creation of notes does not work for entries (PHP 8.3.6) #98

Open
KiralyCraft opened this issue Apr 17, 2024 · 1 comment · May be fixed by #99
Open

Creation of notes does not work for entries (PHP 8.3.6) #98

KiralyCraft opened this issue Apr 17, 2024 · 1 comment · May be fixed by #99

Comments

@KiralyCraft
Copy link

KiralyCraft commented Apr 17, 2024 •
edited

I'm trying to add notes to an article on a system with Apache, php-fpm and PHP 8.3.6

It seems to give this error, and no notes are saved:

E_DEPRECATED: Creation of dynamic property HTMLPurifier_Lexer_DOMLex::$_entity_parser is deprecated

I'm currently at commit f94037241c1827a1b6ac8c555edd09f367032d3b
@KiralyCraft
Copy link
Author

KiralyCraft commented Apr 17, 2024 •
edited

I seem to have fixed it. I downloaded version 0.14.15 of HTMLPurifier from here, and replaced the contents of i-librarian-free/classes/libraries/htmlpurifier with the contents of the library folder from the archive.

I only used the HTMLPurifier folder, the HTMLPurifier.php file and the HTMLPurifier.includes.php file. I renamed HTMLPurifier.php to something_else.php, renamed HTMLPurifier.includes.php to htmlpurifier.php and then edited it to require 'something_else.php' instead of require 'HTMLPurifier.php.

It seems to save notes correctly now.

I will create a PR, should I find the time. Thank you for this amazing piece of software.

@KiralyCraft KiralyCraft linked a pull request Apr 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated HTMLPurifier to 0.14.15 for PHP 8.3.6 KiralyCraft/i-librarian-free
1 participant
@KiralyCraft