Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename normalize to subscale_by #223

Open
11 tasks
mjskay opened this issue Apr 5, 2024 · 0 comments
Open
11 tasks

Rename normalize to subscale_by #223

mjskay opened this issue Apr 5, 2024 · 0 comments

Comments

@mjskay
Copy link
Owner

mjskay commented Apr 5, 2024

Per discussion here: #219 (comment)

I think something like subscale_by would be more descriptive and would be more consistent with the new subscale and subguide params.

  • add subscale_by with options:
    • NULL or character() <=> normalize = "all"
    • "panels" (or maybe "panel") <=> normalize = "panels"
    • "xy" <=> normalize = "xy"
    • "groups" (or maybe "group") <=> normalize = "groups"
    • character vector = group by those columns in the layer data frame
  • deprecate normalize
    • do the same thing I did with slab_type (keep an internal copy of the old param to detect use)
    • if someone uses normalize = "none" point them to subscale = "identity" instead
    • if someone uses normalize = "all" point them to subscale_by = NULL instead
    • otherwise point them to subscale_by = ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant