-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
variant of vline / hline with ribbon #140
Comments
Name is one question... seems odd to have a geom_hlineribbon and geom_vlineribbon in this modern orientation-aware ggplot landscape. Maybe geom_hvlineribbon? Feels awkward. |
looking at some related words and synonyms there's stuff like: axis-aligned, parallel, flat, flush, rule, ... no great names, and vlineribbon / hlineribbon are probably the most discoverable. So maybe use those names as aliases for each other / hvlineribbon and let orientation detection do its work. |
also a vribbon and hribbon variant probably |
Also consider: should this have a gradient variant that allows mapping pdf/cdf? Would actually work easily here unlike with lineribbon. |
more thoughts: the gradient pdf/cdf thing isn't really worth it atm. This should be doable by making sure geom_lineribbon works with infinite bounds. So I'd say the simple version of this is something like:
|
Might be nice to have a version of lineribbon / pointinterval that acts like geom_vline / geom_hline plus a ribbon. See e.g. https://twitter.com/SolomonKurz/status/1546241985597546497?s=20&t=ezZYkV4REc7LfdfFvYAPOg
The text was updated successfully, but these errors were encountered: