-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failures within glob!
& allow_duplicates!
should show output
#424
Comments
Would it be possible to submit a PR here with an improved behavior? I'm not sure I have the cycles at the moment to look at this. I also get output from the glob failures locally so not sure why/how they do not show up. |
Totally reasonable! I would love to spend some more time on insta, and I will try and get to this specific thing. (though not in the very short term, so if anyone sees this, please don't let me stop you). Possibly broadening out to reworking the Tangentially related — there are a few PRs I'm waiting for reviews on: #385, mitsuhiko/insta-website#17, mitsuhiko/insta-website#18 — but also very much understand that the first one is quite a big change. |
FYI I updated this to specific to |
glob!
could show outputglob!
& allow_duplicates!
should show output
If a normal snapshot doesn't match, we get a very nice output:
But in a
glob!
expression (edit: withinallow_duplicates!
), we don't:This is unfortunate since often in a
glob!
&allow_duplicates!
we especially want to have the context. For example here we useglob
&allow_duplicates
to run over multiple queries and multiple dialects, and usedescription
to communicate this so we know which dialect was running when we hit a failure — information that's now lost.In addition, running with
--accept --unreference=auto
seems to clear any other snapshots resulting from theglob!
; I guess because the test is interrupted butcargo-insta
doesn't realize that when cleaning up snapshots. (edit: fixed with #440)(I realize these examples aren't minimally reproducible — I wanted to get something down but can come back and amend if that's helpful)
The text was updated successfully, but these errors were encountered: