Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OpenSSL as a dependency #66

Closed
alilleybrinker opened this issue May 13, 2024 · 1 comment · Fixed by #80
Closed

Remove OpenSSL as a dependency #66

alilleybrinker opened this issue May 13, 2024 · 1 comment · Fixed by #80
Assignees
@mchernicoff
Labels
type: enhancement New feature or request
Milestone
3.3.0

Comments

@alilleybrinker
Copy link
Collaborator

OpenSSL is currently causing GitHub Actions failures for the tasks trying to create pre-built binaries for our releases. More generally, linking with OpenSSL is a pain and source of complexity in building and distributing Hipcheck, and Rustls is far enough along that I think we can feel comfortable transitioning to it.
@alilleybrinker alilleybrinker added the type: enhancement New feature or request label May 13, 2024
@alilleybrinker alilleybrinker added this to the 3.3.0 milestone May 13, 2024
@alilleybrinker
Copy link
Collaborator Author

I believe the specific solution here would be to move away from native-tls, which we use through ureq and also import directly.

@mchernicoff mchernicoff linked a pull request May 20, 2024 that will close this issue
Chore: Remove OpenSSL as a Hipcheck dependency #80
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mchernicoff mchernicoff

Labels
type: enhancement New feature or request
Projects
Hipcheck 2024
Status: Done
Milestone
3.3.0
Development

Successfully merging a pull request may close this issue.

Chore: Remove OpenSSL as a Hipcheck dependency mitre/hipcheck
2 participants
@alilleybrinker @mchernicoff