Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid rerunning all tests on no-code PRs #49

Closed
alilleybrinker opened this issue May 7, 2024 · 0 comments · Fixed by #68
Closed

Avoid rerunning all tests on no-code PRs #49

alilleybrinker opened this issue May 7, 2024 · 0 comments · Fixed by #68
Assignees
@mchernicoff
Labels
type: enhancement New feature or request
Milestone
3.3.0

Comments

@alilleybrinker
Copy link
Collaborator

Right now if a PR is made against the Hipcheck repo which doesn't change the contents of the Hipcheck code, all tests are still re-run. This is a waste of compute time, and also slows down the ability to accept / merge no-code changes to Hipcheck. We ought to make the GitHub Actions configuration smarter, to ignore changes outside of the hipcheck/, config/, xtask/, and scripts/ folders.
@alilleybrinker alilleybrinker added the type: enhancement New feature or request label May 7, 2024
@alilleybrinker alilleybrinker added this to the 3.3.0 milestone May 7, 2024
@mchernicoff mchernicoff linked a pull request May 13, 2024 that will close this issue
chore: Do not run tests if changes outside code folders #68
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mchernicoff mchernicoff

Labels
type: enhancement New feature or request
Projects
Hipcheck 2024
Archived in project
Milestone
3.3.0
Development

Successfully merging a pull request may close this issue.

chore: Do not run tests if changes outside code folders mitre/hipcheck
2 participants
@alilleybrinker @mchernicoff