Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version control for an OHDF file in Heimdall Server #5351

Open
wdower opened this issue Dec 18, 2023 · 0 comments
Open

Version control for an OHDF file in Heimdall Server #5351

wdower opened this issue Dec 18, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@wdower
Copy link
Contributor

wdower commented Dec 18, 2023

If you save over the same filename in Heimdall (i.e. by uploading the same scan filename twice) it should keep the first version in version control.

Right now, if you upload a file to the server that has the same name as an existing file, the older one is simply overwritten. This means that if you do something like set up an automated scan that periodically scans one single target, and you want to compare those scans using Comparison View to see how the target's security is trending (which is a very important part of Heimdall!) you have to be sure to make each filename unique before you upload it (such as by appending a timestamp). Heimdall should really be robust enough to track old versions of HDF so that people don't cut themselves by uploading a colliding name.

This feature will become more necessary when we:

  • Enable Checklist editor (Checklist Editor for Heimdall #3315). That will allow the editing of OHDF files; users will want to be able to backdate the file if they make a mistake.
  • Make Heimdall and the OHDF schema "target-aware" (related to OHDF reporter plugin for InSpec #5350) -- if we give Heimdall a concept of "systems" in addition to just "OHDF files" like it does now, people are going to want to simply upload files named after that system and expect Heimdall to keep track of its history.

Expected features:

  • As a Heimdall user, I want to be able to view, edit, and download an older version of an OHDF file I uploaded to Heimdall from before I edited it with the checklist editor or added a manual attestation to the data.
  • As a Heimdall user, I want to be able to easily restore an old version of an OHDF file to be the current "active" version of a scan result, just in case I make a mistake editing.
  • As a pipeline engineer, I want to be able to see the original, unedited OHDF file that Heimdall first saw (i.e. the first version in version control) so that I can make sure I know what my automated pipeline sent to the Heimdall server.
@wdower wdower added the enhancement New feature or request label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant