You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NB: I stumbled upon this bug while investing #2887. I will most likely submit PRs for the both of them.
The function b64DecodeUnicode(plugins\magma\src\utils\utils.js) used in updateLink (plugins\magma\src\stores\operationStore.js) fails when some characters are present in the command. More characters may cause the error, but here's those I confirmed (will update this if necessary):
dot .
dollar $
Edit: since the root cause is atob() (I found out that Edge is a bit more talkative than Firefox while testing), I expect any string that is not a proper b64 string to fail.
Error triggered: DOMException: String contains an invalid character (firefox) DOMException: Failed to execute 'atob' on 'Window': The string to be decoded is not correctly encoded. (edge)
To Reproduce
Steps to reproduce the behavior:
In an operation started in manual mode, approve a link whose command contains a dot . (it needs to be present in the adversary, not edited in).
Expected behavior
The approval should not restrict supported characters differently than the characters usually supported in abilities.
Desktop (please complete the following information):
Looks like your first issue -- we aim to respond to issues as quickly as possible. In the meantime, check out our documentation here: http://caldera.readthedocs.io/
Describe the bug
NB: I stumbled upon this bug while investing #2887. I will most likely submit PRs for the both of them.
The function
b64DecodeUnicode
(plugins\magma\src\utils\utils.js
) used inupdateLink
(plugins\magma\src\stores\operationStore.js
) fails when some characters are present in the command. More characters may cause the error, but here's those I confirmed (will update this if necessary):.
$
Edit: since the root cause is
atob()
(I found out that Edge is a bit more talkative than Firefox while testing), I expect any string that is not a proper b64 string to fail.Error triggered:
DOMException: String contains an invalid character
(firefox)DOMException: Failed to execute 'atob' on 'Window': The string to be decoded is not correctly encoded.
(edge)To Reproduce
Steps to reproduce the behavior:
.
(it needs to be present in the adversary, not edited in).Expected behavior
The approval should not restrict supported characters differently than the characters usually supported in abilities.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: