Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker containers generate insecure config #2737

Closed
rquarry opened this issue Mar 13, 2023 · 3 comments
Closed

Docker containers generate insecure config #2737

rquarry opened this issue Mar 13, 2023 · 3 comments

Comments

@rquarry
Copy link

rquarry commented Mar 13, 2023

Describe the bug
In the Installing CALDERA section of the docs:

  • Following the "concise" installation instructions for a host based install results in secure configuration values in conf/local.yml.
  • Building via the "Docker Deployment" section of the installation guide results in containers that have default config values for API tokens, user passwords, etc.
  • Issue is due to line 25 in the Dockerfile that pre-creates local.yml, which causes app/utility/config_generator.py to skip creating secure config values when server.py is run.

To Reproduce
Steps to reproduce the behavior:

  1. Follow build documentation for "Docker Deployment"
  2. Observe contents of conf/local.yml: docker exec -it [Container ID] cat conf/local.yml
  3. Comment out line 25 of Dockerfile, re-build/run container.
  4. Observe conents of conf/local.yml

Expected behavior
local.yml should contain unique values upon execution of server.py. This is especially true for containers that may have multiple instances.

Screenshots
User results after standard Docker container build and run:
image
User results after commenting out line 25 of Dockerfile and rebuilding container:
image

Desktop (please complete the following information):

  • OS: Fedora 37
  • Browser: Firefox
  • Version: 4.1.0

I am happy to submit a PR for this, but wasn't sure what to do about disabling the Atomic plugin in the Dockerfile. Perhaps it should be removed from the default config?

@github-actions
Copy link

Looks like your first issue -- we aim to respond to issues as quickly as possible. In the meantime, check out our documentation here: http://caldera.readthedocs.io/

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions
Copy link

github-actions bot commented May 1, 2023

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants