Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert private functions to protected #232

Open
dehartb opened this issue Sep 21, 2022 · 2 comments
Open

Convert private functions to protected #232

dehartb opened this issue Sep 21, 2022 · 2 comments

Comments

@dehartb
Copy link

dehartb commented Sep 21, 2022

Any particular reason that the functions setXForwardedForHeader and getContentLength are not protected instead of private? This allows others to extend this class without the need to modify it.

@dsmiley
Copy link
Collaborator

dsmiley commented Sep 21, 2022

It's easy to overlook this. I definitely think setXForwardedForHeader ought to be protected. I'm not sure why getContentLength would need to be overridden but, hey, why not.

@dehartb
Copy link
Author

dehartb commented Sep 21, 2022

Thanks for the quick response. setXForwardedForHeader was definitely the one I was thinking of, but just added the only other private function in that class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants