Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open edx (maple): Update header to show user's name rather than user's username #2342

Open
2 tasks
briangrossman opened this issue Jan 20, 2022 · 5 comments · Fixed by openedx/frontend-platform#285 or mitodl/frontend-component-header-mitol#3
Assignees

Comments

@briangrossman
Copy link
Contributor

As an xPRO user, I'd like my name to appear in the pulldown in the header in edX rather than my username.

Designs and Mockups

Old Header - Uses name
image

New Header - Uses username
image

Acceptance Criteria:

  • Update frontend-component-header-mitol to default to showing the username, but support the ability to show the name in the pulldown in the upper right.
  • Update xPRO to show the name rather than username

Related Issues:

#2331

@asadiqbal08 asadiqbal08 self-assigned this Feb 9, 2022
@asadiqbal08
Copy link
Contributor

asadiqbal08 commented Feb 10, 2022

@briangrossman Do you have any reference for Old Header that Uses name ? It seems to me, the frontend-platform is not passing out the name property either that is manipulating in authenticatedUser here

So taking out the name,

  • We have to either fork the frontend-platform in mitodl and use this (after modification) OR
  • Create an upstream PR in edx frontend-platform repo for the corresponding change.

@briangrossman
Copy link
Contributor Author

@asadiqbal08

Sorry... the phrase I used old header isn't very helpful. You can view this in the Legacy experience. Or the UI before the MFE for the header was in place.

Some ways to view it:

  • If you're logged in as an admin (I believe), you can see a link for Legacy experience. When you switch over, you will see the username in the header
    image
  • If you are staff for a course, you can click on the Instructor tab. This will open with the pre-MFE version of the header:
    image

Hopefully that helps.

@asadiqbal08
Copy link
Contributor

@briangrossman my point is that, for that change "Showing name" in header MFE needs to update the frontend-platform MFE. If you require that change then I can create an upstream PR in edx Frontend-platform to accommodate the user's name information

@asadiqbal08
Copy link
Contributor

Created a demo PR for reference purposes

@briangrossman
Copy link
Contributor Author

Reopening because this isn't in place yet on production.

@briangrossman briangrossman reopened this Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants