Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix Chromatic test fails #13826

Merged
merged 2 commits into from
May 18, 2024

Conversation

zyoshoka
Copy link
Contributor

What

Chromatic テストが落ちるのに対して場当たり的な処置を行います。

Why

See https://www.chromatic.com/build?appId=6428f7d7b962f0b79f97d6e4&number=2584

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.94%. Comparing base (f8261a1) to head (2853f67).
Report is 556 commits behind head on develop.

❗ Current head 2853f67 differs from pull request most recent head b4c164d. Consider uploading reports for the commit b4c164d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13826      +/-   ##
===========================================
- Coverage    79.95%   77.94%   -2.02%     
===========================================
  Files          956      185     -771     
  Lines       108864    25540   -83324     
  Branches      8413      487    -7926     
===========================================
- Hits         87045    19906   -67139     
+ Misses       21819     5627   -16192     
- Partials         0        7       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zyoshoka
Copy link
Contributor Author

@zyoshoka zyoshoka marked this pull request as ready for review May 13, 2024 14:44
@syuilo syuilo merged commit def7b8c into misskey-dev:develop May 18, 2024
19 checks passed
@syuilo
Copy link
Member

syuilo commented May 18, 2024

🙏

@zyoshoka zyoshoka deleted the fix-chromatic branch May 18, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants