You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
noCountryFlags: false does still hide flag emojis on ms windows with the native emoji set.
I replace the native emoji font inside of my css, with google noto color emoji which does support country flags:
@font-face {
font-family:'EmojiMart';
src:local('Apple Color Emoji'),url("noto/emoji/NotoColorEmoji.ttf") format("truetype");
}
But emoji mart checks only for the native font and does not notice that the 'EmojiMart' font was set:
B. isEmojiSupported() check should include 'EmojiMart' font
probably easy to do (just add it to native-support.ts#L64), but there is the question whether this introduces a race condition where the css stylesheet is loaded after emoji mart did the check.
The text was updated successfully, but these errors were encountered:
Simon-Laux
changed the title
noCountryFlags: false does still hide country flag emojis on windowsnoCountryFlags: false does still hide country flag emojis on windows, even though my custom font supports it
Mar 1, 2023
Simon-Laux
changed the title
noCountryFlags: false does still hide country flag emojis on windows, even though my custom font supports itnoCountryFlags: false does still hide country flag emojis on windows, even though my custom font supports them
Mar 1, 2023
Simon-Laux
added a commit
to Simon-Laux/emoji-mart
that referenced
this issue
Mar 1, 2023
not sure how this would help, this injects a custom font (same as I do in my project), but emoji mart tests for flag support with 2 specific system fonts on a canvas, the injected font will not be part of that.
noCountryFlags: false
does still hide flag emojis on ms windows with thenative
emoji set.I replace the native emoji font inside of my css, with google noto color emoji which does support country flags:
But emoji mart checks only for the native font and does not notice that the
'EmojiMart'
font was set:emoji-mart/packages/emoji-mart/src/helpers/native-support.ts
Line 64 in d29728f
Possible Solutions
A.
noCountryFlags
property should respect falsenoCountryFlags should autodetect when it is set to
undefined
and respect my preference when I set it to a booleantrue
orfalse
:PR that implements this solution: #809
B.
isEmojiSupported()
check should include'EmojiMart'
fontprobably easy to do (just add it to native-support.ts#L64), but there is the question whether this introduces a race condition where the css stylesheet is loaded after emoji mart did the check.
The text was updated successfully, but these errors were encountered: