Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure on Windows. #115

Open
strue36 opened this issue Mar 30, 2023 · 1 comment
Open

Test failure on Windows. #115

strue36 opened this issue Mar 30, 2023 · 1 comment

Comments

@strue36
Copy link
Contributor

strue36 commented Mar 30, 2023

test_read_graphql_file_with_invalid_file_raises_invalid_graphql_syntax_exception() checks for the file path in the expected exception message, but this gets escaped on Windows.

I don't think that this check is necessary and suggest removing it.

assert str(incorrect_schema_file) in str(exc)
@rafalp
Copy link
Contributor

rafalp commented Mar 30, 2023

This assert verifies that error reporting names the faulty file. I'll rather keep it and fix it that remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants