Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown linting rules #432

Open
galaxyfeeder opened this issue Apr 27, 2024 · 2 comments
Open

Markdown linting rules #432

galaxyfeeder opened this issue Apr 27, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@galaxyfeeder
Copy link

We are using for our strings markdown syntax to be able to define bold and links from the string itself.

Will it make sense for this project, if we open a PR adding two new checks (one for bold, and one for links) that compare the count of bold matches between the master value and the value?

Similar to the current check for url_count (lib/lint/checks/url_count.ex).

@simonprev
Copy link
Member

I’m open to a PR addressing this 😃 I’m not sure it’s a fit for every project since "bold" markup should not depends on translations. The URL one ensure that the same information is on every translations but I’m not sure that the same number of "bold" or "italic" markup is a good check.

@simonprev simonprev added the enhancement New feature or request label May 7, 2024
@galaxyfeeder
Copy link
Author

Maybe it would make sense to allow to configure which checks do you want to apply on the dashboard? From what I've seen, the call that is made on the dashboard requests for a lint specifying the complete list of checks. I'm thinking on allowing to configure a project wide setting that defines which ones are active or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants