Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xliff support broken for multiple files #107

Open
kwojtaszek opened this issue Jul 14, 2019 · 1 comment
Open

Xliff support broken for multiple files #107

kwojtaszek opened this issue Jul 14, 2019 · 1 comment

Comments

@kwojtaszek
Copy link

kwojtaszek commented Jul 14, 2019

I found out that accent has issues with xliff files that includes multiple files inside as an array.
Looking into code spotted, that this part has issues: https://github.com/mirego/accent/blob/master/lib/langue/formatter/xliff_1_2/parser.ex#L11
While files may be also an array:

 {'{urn:oasis:names:tc:xliff:document:1.2}xliff',
  [
    {'{http://www.w3.org/2001/XMLSchema-instance}schemaLocation',
     'urn:oasis:names:tc:xliff:document:1.2 http://docs.oasis-open.org/xliff/v1.2/os/xliff-core-1.2-strict.xsd'},
    {'version', '1.2'}
  ],
  [
    {'{urn:oasis:names:tc:xliff:document:1.2}file',
     [
       {'datatype', 'plaintext'},
       {'target-language', 'en'},
       {'source-language', 'en'},
       {'original', 'MobileSeller/Base.lproj/LaunchScreen.storyboard'}
     ],

Example file: https://share.getcloudapp.com/RBu7xZNp

@kwojtaszek
Copy link
Author

Initial work #110

@simonprev simonprev mentioned this issue Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant