Recursively search upwards for a changie config #652

miniscruff · 2024-05-10T08:38:49Z

Closes #651

Check the following

Maintain high code coverage
Be properly formatted
Documentation changes are included
Include a change file if expected

Additional context
I am not sure if this should be behind a flag or env var or anything.
It should work just like git and that seems to work for everyone.

* Not sure if there is a better way, but we just keep going up until going up does nothing. Also upgrade linter and go version.

* too many failures, trying something else

codacy-production · 2024-05-11T18:12:05Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `149452a`¹	✅ 77.78%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`149452a`)	Report Missing	Report Missing	Report Missing
Head commit (`1f43a20`)	2417	2253	93.21%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#652)	27	21	77.78%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov · 2024-05-11T23:43:27Z

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 91.48%. Comparing base (5677d94) to head (b5dbc7d).
Report is 2 commits behind head on main.

❗ Current head b5dbc7d differs from pull request most recent head 1f43a20. Consider uploading reports for the commit 1f43a20 to get more accurate results

Files	Patch %	Lines
core/config.go	68.42%	3 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
- Coverage   95.78%   91.48%   -4.30%     
==========================================
  Files          15       20       +5     
  Lines        1661     1891     +230     
==========================================
+ Hits         1591     1730     +139     
- Misses         35      104      +69     
- Partials       35       57      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

miniscruff added 3 commits May 10, 2024 01:33

Recursively search upwards for a changie config

190046e

* Not sure if there is a better way, but we just keep going up until going up does nothing. Also upgrade linter and go version.

upgrade go version in build docs as well

b5dbc7d

switch to codacy from codecov

e0a6e0e

* too many failures, trying something else

Repository owner deleted a comment from codecov bot May 11, 2024

Merge branch 'main' into 651-recursively-search-for-config

1f43a20

miniscruff merged commit fa5835d into main May 11, 2024
4 of 5 checks passed

miniscruff deleted the 651-recursively-search-for-config branch May 11, 2024 23:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Recursively search upwards for a changie config #652

Recursively search upwards for a changie config #652

miniscruff commented May 10, 2024

codacy-production bot commented May 11, 2024 •

edited

codecov bot commented May 11, 2024

Recursively search upwards for a changie config #652

Recursively search upwards for a changie config #652

Conversation

miniscruff commented May 10, 2024

codacy-production bot commented May 11, 2024 • edited

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

codecov bot commented May 11, 2024

Codecov Report

codacy-production bot commented May 11, 2024 •

edited