Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute mingw-builds changes upstream #5

Open
ogrisel opened this issue Feb 21, 2016 · 4 comments
Open

Contribute mingw-builds changes upstream #5

ogrisel opened this issue Feb 21, 2016 · 4 comments
Milestone

Comments

@ogrisel
Copy link
Contributor

ogrisel commented Feb 21, 2016

Most changes from the mingwpy-dev branch of the mingwpy/mingw-builds repo could be contributed upstream as additional options. Let's try to contribute them as individual pull requests to see if upstream is interested.

@ogrisel
Copy link
Contributor Author

ogrisel commented Feb 22, 2016

For reference here is the link to the commits of the mingwpy-dev branch:

https://github.com/mingwpy/mingw-builds/commits/mingwpy-dev

@carlkl
Copy link
Contributor

carlkl commented Feb 22, 2016

@ogrisel, I propose to first test the latest checkins and then decide howto spilt this into individual PRs for upstream. The latest checkins have to be partially reworked: i.e. the patch for mingw-w64-crt https://github.com/mingwpy/mingw-builds/blob/aa34b84eab6e5a7c044c26f87940e68e53da92ed/patches/mingw-w64/fpclassify.patch should be written partially not as patch but as perl or sed script. I haven't worked this out yet.

@carlkl
Copy link
Contributor

carlkl commented Apr 21, 2016

Probably I will create a repository with simpler and easier to maintain build scripts rather than sitting on the top of https://github.com/niXman/mingw-builds.
The problem with this approach is to stay in sync with all of the necessary patches of the original https://github.com/niXman/mingw-builds. These patches however have to be revised anyway and checked against the gcc patches of https://github.com/Alexpux/MINGW-packages/tree/master/mingw-w64-gcc-git. In the long term such a repository will be easier to maintain compared to patching or hacking mingw-builds.

@techtonik
Copy link
Contributor

Do you plan to make the process system independent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants