Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation for required_status_checks contexts #147

Open
0x46616c6b opened this issue Jan 31, 2023 · 1 comment · May be fixed by #151
Open

Deprecation for required_status_checks contexts #147

0x46616c6b opened this issue Jan 31, 2023 · 1 comment · May be fixed by #151

Comments

@0x46616c6b
Copy link
Contributor

The Terraform GitHub Provider deprecated the field contexts and from now on checks should be used. Would be good to reflect this change in the module.

Warning: "required_status_checks.0.contexts": [DEPRECATED] GitHub is deprecating the use of contexts. Use a checks array instead.

@Cyb3r-Jak3 Cyb3r-Jak3 linked a pull request Mar 12, 2023 that will close this issue
@stefanschulte
Copy link

Any hope to see a timely smaller release to fix this one? I don't think it's configurable on my end, but since 1-2 days every terraform run now generates a change for the new checks field:

  # module.repository["service-core"].github_branch_protection_v3.branch_protection[0] will be updated in-place
  ~ resource "github_branch_protection_v3" "branch_protection" {
        id                              = "service-core:main"
        # (6 unchanged attributes hidden)
      ~ required_status_checks {
          ~ checks         = [
              - "continuous-integration/jenkins/pr-head",
              - "continuous-integration/jenkins/pr-head:0",
            ]
            # (3 unchanged attributes hidden)
        }
    }

And it sadly doesn't persist it, so the same fields come up on every subsequent run again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants