Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for CLI variables #675

Open
lovro-bikic opened this issue Aug 11, 2021 · 0 comments
Open

Better support for CLI variables #675

lovro-bikic opened this issue Aug 11, 2021 · 0 comments
Assignees
Milestone

Comments

@lovro-bikic
Copy link
Member

Mina has a feature which allows overriding variables (set using set method) with environment variables, e.g. rails_env=production mina deploy will override rails_env variable set in config/deploy.rb. While this is a useful feature, it also causes unexpected issues.

For example, one variable Mina uses is called user. Windows environments have a USER environment variable, however, since they're case-insensitive, it can be accessed as lowercase user, so it will override a Mina-set user variable.

Instead of environment variables, we should find another way of supporting variables through CLI. One of the proposed solutions is to take an approach similar to that of docker run command, which accepts variables as an option (see docs). The above example command would then look like this: mina deploy --env rails_env=production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant