-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting the following warnings when using bundler 2.1.2 #657
Comments
same warnings here with Bundler 2.1.4 And
|
Any further info on this? |
For anyone arriving here, I am using the following solution: First I remove the default bundler options. set :bundle_options, -> { '' } Then I add the following to my command "#{fetch(:bundle_bin)} config set deployment 'true'"
command "#{fetch(:bundle_bin)} config set path '#{fetch(:bundle_path)}'"
command "#{fetch(:bundle_bin)} config set without '#{fetch(:bundle_withouts)}'" This solves the depreciation warnings and sets the bundle config globally. I would be happy to write a patch for this if it is something that will get merged. Blog post here: Mina deployments causing Bundler depreciation warnings. |
This would break for anyone using Bundler 1. And I'm not sure Mina team wants to handle a code with an An opinion from them would help the direction of a PR |
@Haelle Surely compatibility with the latest stable Bundler would be preferable, as upgrades are recommended. Mina could recommend a newer and therefore more stable version of Bundler. Currently Mina is unusable with the latest production Bundler. |
+1 |
Hi @thelucid can you explain that more detailed.
|
@thelucid said:
Doesn't it make more sense to use: namespace :bundle do
desc 'Sets the Bundler config options.'
task :config do
comment %{Setting the Bundler config options}
command %{#{fetch(:bundle_bin)} config set --local deployment 'true'}
command %{#{fetch(:bundle_bin)} config set --local path '#{fetch(:bundle_path)}'}
command %{#{fetch(:bundle_bin)} config set --local without '#{fetch(:bundle_withouts)}'}
end
end … on every deploy (notice the |
The text was updated successfully, but these errors were encountered: