Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small discrepancies in the documentation of oracles #244

Open
miguelgondu opened this issue Apr 10, 2024 · 3 comments
Open

Small discrepancies in the documentation of oracles #244

miguelgondu opened this issue Apr 10, 2024 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers high-priority-post-neurips high priority issue. but will be completed after neurips

Comments

@miguelgondu
Copy link

miguelgondu commented Apr 10, 2024

Describe the bug

I am currently creating an interface for TDC s.t. it works well with SELFIES and other representations of small molecules. In the process I've noticed the following in the documentation of oracles:

  1. It invites the user to create a python env using version 3.7, which is no longer supported by Conda.
  2. In the case of Sitagliptin_MPO,Zaleplon_MPO, Isomers_C7H8N2O2, and Isomers_C9H10N2O2PF2Cl, I'm getting different values for the oracle:

To Reproduce

Using PyTDC==0.4.7, run

from tdc import Oracle

oracle = Oracle(name="Sitagliptin_MPO")

# Running the oracle in the example provided by the docs:
oracle("CC(C)(C)[C@H]1CCc2c(sc(NC(=O)COc3ccc(Cl)cc3)c2C(N)=O)C1")

Expected behavior

  • For Sitagliptin_MPO I get 3.34970667598234e-12 instead of 0.00562486906491877
  • For Zaleplon_MPO I get 0.0019017991803329235 instead of 7.752152611462035e-05
  • For Isomers_C7H8N2O2 I get 2.1987591132394053e-34 instead of 7.077155389805107e-22
  • For Isomers_C9H10N2O2PF2Cl I get 1.713908431542013e-15 instead of 3.775134544279098e-11

Environment:

  • OS: MacOS Sonoma 14.4.1
  • Python version: 3.10.12
  • TDC version: 0.4.7
  • Any other relevant information: Can be replicated in Colab easily.
@miguelgondu miguelgondu changed the title Small discrepancies in the documentation Small discrepancies in the documentation of oracles Apr 10, 2024
@amva13 amva13 self-assigned this Apr 10, 2024
@amva13
Copy link
Member

amva13 commented Apr 10, 2024

We use different pickle objects depending on the scikit version and the issue likely lies there

name += "_current"

checking how to resolve

@amva13
Copy link
Member

amva13 commented Apr 10, 2024

I'd imagine the notebook is using an older scikit version in the <= 0.24 range

@amva13 amva13 added bug Something isn't working good first issue Good for newcomers high-priority-post-neurips high priority issue. but will be completed after neurips and removed v2neurips labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers high-priority-post-neurips high priority issue. but will be completed after neurips
Projects
None yet
Development

No branches or pull requests

2 participants