Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8's size is misleading #88

Open
dead-claudia opened this issue Jun 4, 2017 · 3 comments
Open

V8's size is misleading #88

dead-claudia opened this issue Jun 4, 2017 · 3 comments

Comments

@dead-claudia
Copy link

The reported size is of the entire engine, not just the JSON parsing code. It might be better to do one of these two options:

  1. Report the size only for these four files: json-parser.cc, json-parser.h, json-stringifier.cc, and json-stringifier.h.
  2. Just report it as an outlier aside from the size chart, since the parser/stringifier is for an API required by the ECMAScript standard (and thus a size might be misleading), and it wasn't made for typical direct use from C++.
@miloyip
Copy link
Owner

miloyip commented Jun 5, 2017

The code size is the size of executable, not source code. Some big libraries have fewer dependencies so the linked size can be smaller.

This dimension is useful for some people that are looking for tight budget on code size, for example, embedded systems.

@dead-claudia
Copy link
Author

Oh okay. But still, V8's size is misleading for what it is (it's a full on JS engine, and it makes the other libraries' sizes seem microscopic in comparison).

That's what I was referring to, and why I filed the issue.

@miloyip
Copy link
Owner

miloyip commented Jun 5, 2017

I agree that they are not the same type of libraries.
The test suite also includes QT which is a complete application framework.
However, I think the chart is not very useful now, due to compressing those need to be compared.
I will consider better presentation of data, and/or adding some notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants