Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json Spirit is mentioned in the list of 43 libraries but not in the test results. Why? #110

Open
RokerHRO opened this issue Oct 10, 2018 · 3 comments

Comments

@RokerHRO
Copy link

The table of the 43 libraries contains "json spirit" with version 4.08, but I cannot find any test results.
Why? Does it not parse the test data?

@boazsegev
Copy link
Contributor

AFAIK, the results were last updated in 2016.

To view updated results, with all the updated libraries, compile and run the project on your machine.

@RokerHRO
Copy link
Author

  1. "last updated in 2016" is no excuse to list a certain library first but don't mention it in the results. Perhaps there was a reason for it? I don't know.
  2. It is far more complicated for me to install all the competitors than it would be for the author of the project who had already done it. And when the results depend on the specific machine and OS it would not help if I just try it now on my machine.

@boazsegev
Copy link
Contributor

@RokerHRO ,

I truly understand your sentiment. I'm not the author for this repo, I am a user, much like yourself and running the benchmarks was a struggle (you can see my results here).

However, I also understand that benchmarking costs money and time. Moreover, the results are often machine specific.

I wish the author was sponsored and automated benchmarks were run after every PR... however, this does not appear to be the case.

The author was kind enough to donate their time and resources, sharing their knowledge to help the community... This is a gift we were given.

Of course, there is always more to do... but it's free, so there it is. Nothing to say but "thank you".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants