Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDN link broken #250

Closed
swalberg opened this issue Jun 6, 2020 · 6 comments
Closed

CDN link broken #250

swalberg opened this issue Jun 6, 2020 · 6 comments
Assignees

Comments

@swalberg
Copy link

swalberg commented Jun 6, 2020

Version info

Milligram: Latest (From CDN)

Other (e.g. normalize.css, node.js, npm, bower, browser, operating system) (if applicable):

Test case

Using the link from the "Getting started" page: cdn.rawgit.com/milligram/milligram/master/dist/milligram.min.css, it's a 404.

Steps to reproduce

  1. Install Milligram via CDN links in the getting started guide
  2. Observe that Milligram CSS is a 404

Expected behavior

A 200 followed by the CSS for milligram

Actual behavior

A 404

It looks like /dist was removed from this repo some time ago but rawgit.com only finally purged it from cache. I'm not sure when since this is on a site I don't look at much, maybe within the last month.

For CDNs, rawgit.com is also going away. The rawgit.com page lists some alternatives.

@dohliam
Copy link

dohliam commented Jun 8, 2020

It looks like the dist folder was removed in this commit on June 1.

@cjpatoilo is there any chance you might consider restoring the dist folder with the (minified and unminified) CSS source at some point in the future? (For what it's worth, this also broke our ability to update milligram automatically at dropin-minimal-css.)

@cjpatoilo cjpatoilo self-assigned this Jun 8, 2020
@cjpatoilo
Copy link
Member

@swalberg @dohliam

Please, can you review this pull request #251

@dohliam
Copy link

dohliam commented Jun 8, 2020

@cjpatoilo Thanks so much for the quick fix! It's great to have the compiled CSS available again. 👍

@swalberg
Copy link
Author

swalberg commented Jun 8, 2020

Thank you! Looking forward to seeing this merged!

@cjpatoilo
Copy link
Member

@swalberg @dohliam it's my pleasure to rollback the Rawgit support. So, I just didn't know that there was this problem. I love Rawgit and @rgrove made the huge work.

@cjpatoilo
Copy link
Member

@swalberg @dohliam all done! Now I will close this issue and if you have any questions, please, feel free to reopen this issue or open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants