Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid behavior on mobile #188

Closed
dnohr opened this issue Jan 12, 2018 · 7 comments
Closed

Grid behavior on mobile #188

dnohr opened this issue Jan 12, 2018 · 7 comments

Comments

@dnohr
Copy link

dnohr commented Jan 12, 2018

Version info

  • Milligram 1.3

Steps to reproduce

<div class="row">
<div class="column">test</div>
<div class="column column-20"">test 2</div>
</div>

Expected behavior

I expected to see 100% width on the mobile grid, like other css frameworks are doing it.

Actual behavior

The grid keeps the percentage width but on two lines, which looks strange.

On Desktop

Desktop

On Mobile

Mobile

Any solutions on it or is it the expected behavior?

@cjpatoilo
Copy link
Member

Hey @dnohr Good call!

I really liked the idea. In fact, I had already imagined something like that, but I'm not sure if everyone uses it that way. It would be interesting to map this information. Could you show me what CSS frameworks use 100% on mobile?

@dnohr
Copy link
Author

dnohr commented Feb 7, 2018

Hi @cjpatoilo,

Seems like these frameworks are doing it:

I guess the solution would be to override the "column-20" width 100% if it's on mobile. Would it be possible?

Thanks for your work 👌🏻

@cjpatoilo
Copy link
Member

@dnohr I have found a way to add this support and maintain the current behavior. 👍
Thanks for reporting this improvement.

@martinffx
Copy link

martinffx commented Sep 15, 2018

I'm having the same issue?
How does one resolve this?

On mobile I expect the grid to break the columns into rows and it is staying exactly the same as it was when on desktop.

@celebritydeveloper
Copy link

Can I fix this issue?

@cjpatoilo
Copy link
Member

@celebritydeveloper this behavior was fixed. Look the demo:

milligram-mobile

@cjpatoilo
Copy link
Member

@dnohr @martinffx For now, I will close this issue.
Please, feel free to reopen or open a new one.

@cjpatoilo cjpatoilo self-assigned this May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants