Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on Windows #122

Closed
luisaceituno opened this issue Oct 10, 2016 · 6 comments
Closed

Build fails on Windows #122

luisaceituno opened this issue Oct 10, 2016 · 6 comments
Labels

Comments

@luisaceituno
Copy link

Version info

Milligram: 1.1.0

Other (e.g. normalize.css, node.js, npm, bower, browser, operating system) (if applicable):
"dependencies": {
"normalize.css": "latest"
},
"devDependencies": {
"autoprefixer": "^6.3.6",
"backstopjs": "^1.3.5",
"browser-sync": "^2.13.0",
"node-sass": "^3.7.0",
"npm-run-all": "^2.1.1",
"onchange": "^2.4.0",
"postcss-cli": "^2.5.2",
"sass-lint": "^1.8.2"
}

Windows 10, node v6.5.0, npm 3.10.3

Steps to reproduce

  1. Use Windows
  2. Clone project
  3. run npm run build

Expected behavior

Build is successful.

Actual behavior

Following error:
postcss -u autoprefixer --no-map.inline --autoprefixer.browsers 'last 1 versions' -r dist/*.css

[system_path]\milligram\node_modules\minimatch\minimatch.js:108
throw new TypeError('glob pattern string required')
^

TypeError: glob pattern string required
at new Minimatch ([system_path]\milligram\node_modules\minimatch\minimatch.js:108:11)
at setopts ([system_path]\milligram\node_modules\postcss-cli\node_modules\glob\common.js:112:20)
at new GlobSync ([system_path]\milligram\node_modules\postcss-cli\node_modules\glob\sync.js:38:3)
at Function.globSync as sync
at [system_path]\milligram\node_modules\postcss-cli\node_modules\globby\index.js:55:35
at Array.reduce (native)
at Function.module.exports.sync ([system_path]\milligram\node_modules\postcss-cli\node_modules\globby\index.js:54:19)
at Object. ([system_path]\milligram\node_modules\postcss-cli\index.js:90:21)
at Module._compile (module.js:556:32)
at Object.Module._extensions..js (module.js:565:10)

@cjpatoilo
Copy link
Member

cjpatoilo commented Nov 11, 2016

Hey @luisaceituno

I just update the version. Could you try it one more time?

@mmdsharifi
Copy link

in version 1.2.0 and node 6.9.1, npm 3.10.9 have same error.

after install autoprefixer globally it still have above error. and banner have this error:

> milligram@1.2.0 banner G:\Github\FinalProject\milligram
> for m in dist/*.css; do echo '/*!
 * Milligram v1.2.0
 * http://milligram.github.io
 *
 * Copyright (c) 2016 CJ Patoilo
 * Licensed under the MIT license
*/
' | cat - $m > temp && mv temp $m; done
m was unexpected at this time.
.
.
.

@cjpatoilo cjpatoilo reopened this Nov 19, 2016
@cjpatoilo
Copy link
Member

cjpatoilo commented Nov 19, 2016

Hi @mmdsharifi

So Milligram use npm scripts for build system. You will not need to install any global dependencies. You only need to have the latest version of Node installed and run npm start ornpm install.

Let us know if you need anything else.

@cjpatoilo cjpatoilo added the bug label Nov 19, 2016
@cjpatoilo
Copy link
Member

cjpatoilo commented Nov 22, 2016

@luisaceituno @mmdsharifi I'm working to solve this problem. I added the AppVeyor service to ensure build in Windows environments. To follow, just access this link:
https://ci.appveyor.com/project/cjpatoilo/milligram

@cjpatoilo
Copy link
Member

cjpatoilo commented Dec 2, 2016

@luisaceituno @mmdsharifi

I solved the problem generated by single quotation marks in the auprefixer task. There is now an error in the task banner. In summary this problem is about the variation of shell script commands in Windows and MacOS / Linux environments. I've created a module written in Node.js to solve this problem, but I need more free time to work on it.

If you can help in any way .. here is the link: https://github.com/cjpatoilo/banner-cli

@cjpatoilo
Copy link
Member

cjpatoilo commented Dec 13, 2016

@luisaceituno @mmdsharifi Thank you for reporting this issue. I just extended the node's support. Everything is working well. I'll close this issue but I hope you keep in touch should you need to.

Windows Env: https://ci.appveyor.com/project/cjpatoilo/milligram

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants