Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Validate form to prevent users from selecting invalid sprint dates or not selecting a template. #231

Open
6 tasks
jayeclark opened this issue May 4, 2022 · 4 comments
Labels
design Involves front end design work enhancement New feature or request good first issue Good for newcomers and newer coders help wanted This issue is still active and help is wanted on it! React Involves the React framework

Comments

@jayeclark
Copy link
Collaborator

Description

Currently the Sprint Creation feature allows sprints to be created for any date, including dates in the past. Let's add some form validation/date restriction so that sprints can't be created too far in the past or too far in the future. The earliest sprint date and latest sprint date ranges should be set as consts so that we can easily change them during development to manually test various scenarios. (For example, if I wanted to test a pagination feature, I could temporarily set the start and end of the range to infinity to allow myself to create oodles of sprints in my test account.)

Suggested Enhancements

  • Users should not be able to create sprints that start in the past. The dates should not be able to be selected.
  • Users should not be able to create sprints that start more than 90 days in the future. The dates should not be able to be selected.
  • The create button should not be enabled/clickable until a user has selected a valid date AND selected a sprint template. If they select a template but have not yet selected a date, display a prompt below the create button asking the user to select a date in order to create the sprint. If they select a date but have not yet selected a template, display a prompt below the create button asking the user to select a date in order to create the sprint.
  • Optional: if the user creates a sprint with no competitors, display a modal letting them know that they have not selected any competitors, and give them the option of going forward (creating the sprint) or going back (returning to the form.)
  • Optional: add a tooltip to the dates that can't be selected, indicating why they cannot be selected OR add a note on the page explaining the range of available dates.
  • Optional: complete initial conversion of file to TypeScript

Screen Shot 2022-05-04 at 10 47 10 AM

@jayeclark jayeclark added enhancement New feature or request help wanted This issue is still active and help is wanted on it! good first issue Good for newcomers and newer coders React Involves the React framework design Involves front end design work labels May 4, 2022
@jayeclark jayeclark changed the title Enhancement: Validate form to prevent people from selecting a sprint date too far in the past or not selecting a template. Enhancement: Validate form to prevent people from selecting invalid sprint dates or not selecting a template. May 4, 2022
@jayeclark jayeclark changed the title Enhancement: Validate form to prevent people from selecting invalid sprint dates or not selecting a template. Enhancement: Validate form to prevent users from selecting invalid sprint dates or not selecting a template. May 4, 2022
@jzohdi
Copy link

jzohdi commented May 5, 2022

Hi, I saw that you're looking for help and that this would be a good first issue. I'd like to work on this, can I be assigned to this issue?

@jayeclark
Copy link
Collaborator Author

We’d love the help @jzohdi ! Assigning you now - let me know if I can answer any questions as you get set up.

@jzohdi
Copy link

jzohdi commented May 5, 2022

Thank you! I have created a PR here

@jayeclark
Copy link
Collaborator Author

Wow, super fast!! I won’t be at my PC until tomorrow morning but will take a look when I am!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Involves front end design work enhancement New feature or request good first issue Good for newcomers and newer coders help wanted This issue is still active and help is wanted on it! React Involves the React framework
Projects
None yet
Development

No branches or pull requests

2 participants