Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kemonoparty] filenames can exceed 255 character limit #5575

Open
alexschcom opened this issue May 9, 2024 · 1 comment
Open

[kemonoparty] filenames can exceed 255 character limit #5575

alexschcom opened this issue May 9, 2024 · 1 comment

Comments

@alexschcom
Copy link

alexschcom commented May 9, 2024

On both Mac and Windows, a filename is stored by 8 bits, which results in a max length of 255 characters, including extension.

When downloading from kemono/coomer, the default filename format is set to {id}_{title[:180]}_{num:>02}_{filename[:180]}.{extension}. If title and filename parts are both sufficiently long, this can allow for filenames longer than 255 characters, resulting in failed downloads. (Note also that during downloading, .part files are even longer than the downloaded file...)

Maybe reduce the filename part, as that's arguably the least important part?

EDIT: Problem would be checking for already-downloaded files after change of default filename...

@Hrxn
Copy link
Contributor

Hrxn commented May 9, 2024

Problem would be checking for already-downloaded files after change of default filename...

Not if you're using the archive option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants