Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files #30

Open
gedw99 opened this issue Mar 20, 2023 · 5 comments
Open

Files #30

gedw99 opened this issue Mar 20, 2023 · 5 comments

Comments

@gedw99
Copy link
Contributor

gedw99 commented Mar 20, 2023

How about we use s3 and local ?

The directory info can be in the db.

this is a very standard approach.

so after a file is transacted into the file store and event updates the directory info on the db.

@mikestefanello
Copy link
Owner

Linking the other issue for reference: #10

That approach definitely works but I'm not going to include that unless it's flexible enough to easily support more options. I reviewed many libraries that handle file uploads but I wasn't convinced by any of them; I'm sure there's plenty that I missed though.

@gedw99
Copy link
Contributor Author

gedw99 commented Mar 21, 2023

Linking the other issue for reference: #10

I closed it because it got fill of other junk...

That approach definitely works but I'm not going to include that unless it's flexible enough to easily support more options. I reviewed many libraries that handle file uploads but I wasn't convinced by any of them; I'm sure there's plenty that I missed though.

Maybe suggest what you think is a good approach ? I know there are tons of ways to do this. I presume we want to leverage what we have already in the Architecture. Ent can be used to store the Directory of the files and Minio the actual files.

You can also use Minio as a proxy. Then is someone use Amazon S3 or Google storage minio acts as a proxy and dramatically lowers running costs quite a bit.. This is a complexity but an option.

@gedw99
Copy link
Contributor Author

gedw99 commented Mar 21, 2023

@mikestefanello

Congrats on the Codespaces integration. Worked out of the box. Have to make sure Files concept works this way too.

@mikestefanello
Copy link
Owner

Since this project is meant to be a flexible starter kit, I don't want to include anything unless it's flexible enough to meet most use-cases, or be easily adapted/extended to fit most use-cases. If it's anything specific, then a dev can just choose to integrate that themselves. What we don't want to do is spend time creating or adding something that will get little or no usage - it's just one more thing to maintain. I would like to include something straight-forward to handle file uploads that support multiple/pluggable backends but I haven't come across a project that seemed like a good fit yet. I'll definitely keep looking and please share any projects or solution that come to mind and we'll evaluate them.

@gedw99
Copy link
Contributor Author

gedw99 commented Mar 21, 2023

cool. will have a think...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants