Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to remove footer bottom padding? #2020

Closed
AlexanderIgnacz opened this issue Sep 4, 2017 · 14 comments
Closed

How to remove footer bottom padding? #2020

AlexanderIgnacz opened this issue Sep 4, 2017 · 14 comments
Assignees
Labels

Comments

@AlexanderIgnacz
Copy link

I added StickyDrawerItem to sample application and it works fine but there is bottom padding.
I want to remove this padding.

screenshot_2017-09-05-02-07-05

Is there any simple way to remove this?

@mikepenz
Copy link
Owner

mikepenz commented Sep 4, 2017

@AlexanderIgnacz is you activity in fullscreen mode?

which phone, which library version, which android version, what do you do?

does the same happen in the sample application?

@mikepenz mikepenz self-assigned this Sep 4, 2017
@AlexanderIgnacz
Copy link
Author

AlexanderIgnacz commented Sep 4, 2017

Mode - FullScreen Mode
Library version - 5.9.4

...
.addStickyDrawerItems(new PrimaryDrawerItem().withName(R.string.drawer_item_custom).withIcon(FontAwesome.Icon.faw_eye)
...

@AlexanderIgnacz
Copy link
Author

I'll do some more tests and back again.

@AlexanderIgnacz
Copy link
Author

AlexanderIgnacz commented Sep 5, 2017

So, I tested on other types of drawers and those work fine.
But only for fullscreen mode, there is a unexpected bottom padding.

@mikepenz
Copy link
Owner

mikepenz commented Sep 5, 2017

@AlexanderIgnacz you set the flag as linked by me?

@AlexanderIgnacz
Copy link
Author

Sorry, which flag do you mean?
I see only this line.
public DrawerBuilder withFullscreen(boolean fullscreen) {

@mikepenz
Copy link
Owner

mikepenz commented Sep 5, 2017

yes. did you set withFullscreen true?

@AlexanderIgnacz
Copy link
Author

Yes, I'm testing on example application now.

@AlexanderIgnacz
Copy link
Author

How can I customize footer view so that hide bottom padding?

@mikepenz
Copy link
Owner

mikepenz commented Sep 5, 2017

if withFullscreen(true) is provided in the DrawerBuilder the padding is not added here:
https://github.com/mikepenz/MaterialDrawer/blob/develop/library/src/main/java/com/mikepenz/materialdrawer/DrawerUtils.java#L312

@AlexanderIgnacz
Copy link
Author

Ops, if condition is wrong there.
It should be if (!(drawer.mTranslucentNavigationBar || drawer.mFullscreen) && Build.VERSION.SDK_INT >= 19) {

@AlexanderIgnacz
Copy link
Author

How can I use this change on my current library version 5.9.4?

@mikepenz
Copy link
Owner

mikepenz commented Sep 5, 2017

well as you can't do the change directly in the lib.
I would suggest you get the StickyFooter and set the padding to 0

https://github.com/mikepenz/MaterialDrawer/blob/develop/library/src/main/java/com/mikepenz/materialdrawer/Drawer.java#L358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants