Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First Time Buyer and Previous Patterns are not focusable #343

Open
brooksbecton opened this issue May 6, 2020 · 0 comments · May be fixed by #348
Open

First Time Buyer and Previous Patterns are not focusable #343

brooksbecton opened this issue May 6, 2020 · 0 comments · May be fixed by #348
Labels
bug Something isn't working UI User Interface Issues

Comments

@brooksbecton
Copy link
Contributor

Describe the bug
The radio buttons for the "First Time Buyer" and "Previous Patterns" are not focusable because the actual radio button is not being displayed.

.input__radio-buttons input[type=radio] {
  display: none;
}

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://turnipprophet.io/
  2. Press Tab
  3. The browsers focus goes to the first open input

Expected behavior
The 'First Time Buyer' and 'Previous Patterns' radio buttons are focusable. Someone should be able to 'tab' into those inputs

Additional context
The inputs should be focusable so that users who use assistive technology can interact with them.
They aren't currently focusable because they aren't being displayed. Browsers will do some checking to see if the the HTML element is supposed to be there (this is where display:none is messing it up) and will ignore anything that isn't going to be displayed.

If you delete that line in the css, the radio buttons will come back and this fixes the issue, but it messes up the page visually. I tried to use opacity: 0 to compromise, but still had no luck.

@brooksbecton brooksbecton added the bug Something isn't working label May 6, 2020
davidcorry pushed a commit to davidcorry/ac-nh-turnip-prices that referenced this issue May 6, 2020
@mikebryant mikebryant added the UI User Interface Issues label May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI User Interface Issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants