Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect exception handling #17

Open
r614 opened this issue Nov 10, 2023 · 0 comments
Open

Incorrect exception handling #17

r614 opened this issue Nov 10, 2023 · 0 comments

Comments

@r614
Copy link

r614 commented Nov 10, 2023

The following exception block catches all exceptions without logging anything, making it incredibly difficult to debug the library. For example, bs4 fails to parse the HTML because of an optional lxml parser dependency, but the exception is never raised and the library fails to crawl silently.

)
except:
child_urls = []
page_type = "other"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant