Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement macos file picker using native APIs in the app rather than calling out to osascript #1492

Open
Hixie opened this issue Apr 16, 2024 · 3 comments
Assignees
Labels
feature-candidate This issue might result in a feature to be implemented suggestion New feature or request

Comments

@Hixie
Copy link

Hixie commented Apr 16, 2024

The current approach results in this weird UI experience where the file picker isn't focused correctly, and where there's a new system process for the dialog that is separate from the actual app. It also runs into problems if osascript is disabled for some reason (e.g. security policy).

There doesn't seem to be any reason why we could implement this using regular message channels to code implemented natively in the app, like a normal plugin.

@Hixie Hixie added the suggestion New feature or request label Apr 16, 2024
@navaronbracke navaronbracke added the feature-candidate This issue might result in a feature to be implemented label Apr 16, 2024
@navaronbracke navaronbracke self-assigned this Apr 18, 2024
@navaronbracke
Copy link
Collaborator

@Hixie I'll be able to tackle this myself, after fixing up a large part of the platform interface.

@stuartmorgan
Copy link

Probably one of #1145 and this should be closed, since they seem to be describing the same thing.

@navaronbracke
Copy link
Collaborator

I'll keep this one open, since the title signifies better what is meant to be done in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-candidate This issue might result in a feature to be implemented suggestion New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants