Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify if all properties of IHook are used #10

Open
kbouchard opened this issue Feb 13, 2019 · 0 comments
Open

Verify if all properties of IHook are used #10

kbouchard opened this issue Feb 13, 2019 · 0 comments
Labels
invalid This doesn't seem right question Further information is requested

Comments

@kbouchard
Copy link
Contributor

kbouchard commented Feb 13, 2019

During TypeScript conversion, we noticed that two props in IHook were not documented and might not even be used in the code at all.

Look at this deeper, if they're not used, remove them. If they are, add documentation or evaluate how useful they are.

export interface IHook extends IWrapper {
  [key: string]: any;
  onBeforeMount: (tester: Tester, ops: IMountOps) => void;
  onInit: (tester: Tester) => void;
  props: object | (() => void);
  shortCuts: { [shortCutName: string]: () => void }; // USED ?
  wrapper: () => { Component: Component, name: string, props: object }; // USED ?
}
@kbouchard kbouchard added invalid This doesn't seem right question Further information is requested labels Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant