Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: Mozilla.Thunderbird version 115.10.2 ( breaking change in the upgrade path to version 125.0 ) #152043

Closed
2 tasks done
R-Adrian opened this issue May 3, 2024 · 5 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.

Comments

@R-Adrian
Copy link

R-Adrian commented May 3, 2024

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Installation issue.

Brief description of your issue

related pull request: #151869

version 115.10.2 is not meant to be used for upgrades over anything else in the previous 115 version series because it only introduces a breaking change in the upgrade path:
the automatic upgrade channel for Thunderbird is changed to ESR with this version. Thunderbird 125.0 is almost ready for release.

See https://www.thunderbird.net/en-US/thunderbird/115.10.2/releasenotes/

and also https://ftp.mozilla.org/pub/thunderbird/releases/125.0/

Steps to reproduce

  • Install Thunderbird 115.10.1
  • in the app go to Help -> About to check for self-updates
  • read Release Notes for the version 115.10.2 (next version shown by winget upgrade )

Actual behavior

winget changes upgrade channel of Thunderbird from RELEASE to ESR

Expected behavior

winget should not change the channel.

Environment

env not relevant

Screenshots and Logs

image

https://wiki.mozilla.org/Thunderbird/tb-planning
(screenshot from the Topicbox Thunderbird planning site:)

image

@R-Adrian R-Adrian added the Issue-Bug It either shouldn't be doing this or needs an investigation. label May 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label May 3, 2024
@R-Adrian R-Adrian changed the title [Package Issue]: Mozilla.Thunderbird version 115.10.2 [Package Issue]: Mozilla.Thunderbird version 115.10.2 is not meant for updates (yet) May 3, 2024
@R-Adrian R-Adrian changed the title [Package Issue]: Mozilla.Thunderbird version 115.10.2 is not meant for updates (yet) [Package Issue]: Mozilla.Thunderbird version 115.10.2 is not meant for upgrades (yet) May 3, 2024
@R-Adrian R-Adrian changed the title [Package Issue]: Mozilla.Thunderbird version 115.10.2 is not meant for upgrades (yet) [Package Issue]: Mozilla.Thunderbird version 115.10.2 is not meant for upgrades (breaking change in the upgrade path to version 125.0) May 3, 2024
@R-Adrian R-Adrian changed the title [Package Issue]: Mozilla.Thunderbird version 115.10.2 is not meant for upgrades (breaking change in the upgrade path to version 125.0) [Package Issue]: Mozilla.Thunderbird version 115.10.2 is not meant for upgrades yet (breaking change in the upgrade path to version 125.0) May 3, 2024
@R-Adrian R-Adrian changed the title [Package Issue]: Mozilla.Thunderbird version 115.10.2 is not meant for upgrades yet (breaking change in the upgrade path to version 125.0) [Package Issue]: Mozilla.Thunderbird version 115.10.2 is not meant for upgrades (breaking change in the upgrade path to version 125.0) May 3, 2024
@stephengillie
Copy link
Collaborator

Should this be added as a separate PackageIdentifier, possibly Mozilla.Thunderbird.115?

  • This way, users could upgrade past it without knowing - and if a user really wanted to install it, they would still have an easy way.
  • One caveat is that both versions should be able to be installed side-by-side. If they can't be side-by-side then this suggestion probably won't work.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Triage This work item needs to be triaged by a member of the core team. label May 3, 2024
@stephengillie stephengillie added the Help-Wanted This is a good candidate work item from the community. label May 3, 2024
@R-Adrian
Copy link
Author

R-Adrian commented May 3, 2024

Should this be added as a separate PackageIdentifier, possibly Mozilla.Thunderbird.115?

I think the identifier should be Mozilla.Thunderbird.ESR
the same way that Firefox ESR has the identifier Mozilla.Firefox.ESR
https://github.com/microsoft/winget-pkgs/tree/master/manifests/m/Mozilla/Firefox/ESR

This way when future versions go into extended maintenance we do not have to change the ESR tag.

One caveat is that both versions should be able to be installed side-by-side. If they can't be side-by-side then this suggestion probably won't work.

Not sure yet when/if Mozilla changes how the versions are listed in the registry. If they cannot be differentiated in the future then i think we might have to completely drop the Thunderbird ESR track out of WinGet manifests.

P.S. i decided to manually install 115.10.2 followed by 125.0 - they definitely want to use the same default folder C:\Program Files\Mozilla Thunderbird and i do not want to test if they can actually run side-by-side from different folders as this could break my local mail storage profile.

with version 115.10.2 installed:

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Mozilla Thunderbird 115.10.2 (x64 en-GB)]
"Comments"="Mozilla Thunderbird 115.10.2 (x64 en-GB)"
"DisplayIcon"="C:\\Program Files\\Mozilla Thunderbird\\thunderbird.exe,0"
"DisplayName"="Mozilla Thunderbird (x64 en-GB)"
"DisplayVersion"="115.10.2"
"InstallLocation"="C:\\Program Files\\Mozilla Thunderbird"
"Publisher"="Mozilla"
"UninstallString"="\"C:\\Program Files\\Mozilla Thunderbird\\uninstall\\helper.exe\""
"URLInfoAbout"="https://www.mozilla.org/en-GB/"
"URLUpdateInfo"="https://www.thunderbird.net/en-GB/"
"NoModify"=dword:00000001
"NoRepair"=dword:00000001
"EstimatedSize"=dword:0003bd9c

and with version 125.0 installed:

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Mozilla Thunderbird 125.0 (x64 en-GB)]
"Comments"="Mozilla Thunderbird 125.0 (x64 en-GB)"
"DisplayIcon"="C:\\Program Files\\Mozilla Thunderbird\\thunderbird.exe,0"
"DisplayName"="Mozilla Thunderbird (x64 en-GB)"
"DisplayVersion"="125.0"
"InstallLocation"="C:\\Program Files\\Mozilla Thunderbird"
"Publisher"="Mozilla"
"UninstallString"="\"C:\\Program Files\\Mozilla Thunderbird\\uninstall\\helper.exe\""
"URLInfoAbout"="https://www.mozilla.org/en-GB/"
"URLUpdateInfo"="https://www.thunderbird.net/en-GB/"
"NoModify"=dword:00000001
"NoRepair"=dword:00000001
"EstimatedSize"=dword:0003e3ca

P.S. (2) - i went back to version 115.10.1 and indeed... the upgrade to version 125.0 is not easily rollable back - it changed the user profile so that when i went back to version 115.10.1 this one refused to use it because it was modified by the new major version.
Fortunately i had a copy of the profile that i made this morning so i deleted the now-incompatible folder and copied back in the one from this morning.

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Mozilla Thunderbird 115.10.1 (x64 en-GB)]
"Comments"="Mozilla Thunderbird 115.10.1 (x64 en-GB)"
"DisplayIcon"="C:\\Program Files\\Mozilla Thunderbird\\thunderbird.exe,0"
"DisplayName"="Mozilla Thunderbird (x64 en-GB)"
"DisplayVersion"="115.10.1"
"InstallLocation"="C:\\Program Files\\Mozilla Thunderbird"
"Publisher"="Mozilla"
"UninstallString"="\"C:\\Program Files\\Mozilla Thunderbird\\uninstall\\helper.exe\""
"URLInfoAbout"="https://www.mozilla.org/en-GB/"
"URLUpdateInfo"="https://www.thunderbird.net/en-GB/"
"NoModify"=dword:00000001
"NoRepair"=dword:00000001
"EstimatedSize"=dword:0003bd9c

@SpecterShell
Copy link
Contributor

SpecterShell commented May 4, 2024

It is weird that the official homepage still provides 115.10.2 even if it is in ESR, and there is no specific page for downloading ESR editions.

@R-Adrian
Copy link
Author

R-Adrian commented May 4, 2024

It is weird that the official homepage still provides 115.10.2 even if it is in ESR, and there is no specific page for downloading ESR editions.

I expect that when version 125 is finally qualified for a full release they will start showing two update buttons in the "About" window of Thunderbird - one to stay on the 115 ESR track and one to upgrade to version 125.

Not sure how this will work for people who have already switched to the ESR channel... probably those two buttons will still be shown for them too.

Anyway... the current problem is that we cannot differentiate between Thunderbird (normal release) and Thunderbird ESR just by looking at the registry...
...there is a bug in Bugzilla for this - https://bugzilla.mozilla.org/show_bug.cgi?id=1895080

Firefox ESR had practically the same problem in 2014 - https://bugzilla.mozilla.org/show_bug.cgi?id=726781
and they solved it by adding the "ESR" string to the product name in registry.

@R-Adrian
Copy link
Author

R-Adrian commented May 5, 2024

update: apparently all these years Thunderbird was actually considered to be on the ESR track all along. just not explicitly named as such. i think that also closes this WinGet issue ticket as resolved (for now) too.

quote from Bugzilla:

115.10.1 SHOULD be upgraded to 115.10.2, so there's no bug there.

What's going on here is that Thunderbird hasn't had a "standard release" in many years, we've had ESR rebranded as a "standard release". But we are adding a REAL standard release that updates monthly as it should, so all current users of "release" are really ESR users and are being intentionally relabeled as such.

I believe we are planning to add ESR to the name with version 128.0, which is the first (new) version with actual overlap between the ESR version number and the new "standard release" channel.

/quote

@R-Adrian R-Adrian closed this as completed May 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Help-Wanted This is a good candidate work item from the community. label May 5, 2024
@R-Adrian R-Adrian changed the title [Package Issue]: Mozilla.Thunderbird version 115.10.2 is not meant for upgrades (breaking change in the upgrade path to version 125.0) [Package Issue]: Mozilla.Thunderbird version 115.10.2 ( breaking change in the upgrade path to version 125.0 ) May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

3 participants