Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: Libjxl.Libjxl version 0.10.2 #151388

Closed
wants to merge 3 commits into from
Closed

New package: Libjxl.Libjxl version 0.10.2 #151388

wants to merge 3 commits into from

Conversation

vikingnope
Copy link
Contributor

@vikingnope vikingnope commented Apr 28, 2024 •
edited by microsoft-github-policy-service bot

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Resolves: #151383

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Apr 28, 2024
sidy3d
sidy3d suggested changes Apr 29, 2024
View reviewed changes
Copy link

@sidy3d sidy3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NestedInstallerFiles should reference the following executables:

  • cjxl
  • djxl
  • cjpegli
  • djpegli

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 29, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Apr 29, 2024
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vikingnope
Copy link
Contributor Author

vikingnope commented Apr 29, 2024 •
edited

NestedInstallerFiles should reference the following executables:

* `cjxl`

* `djxl`

* `cjpegli`

* `djpegli`

I do not believe there are those executables in both files.

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Apr 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 29, 2024
sidy3d
sidy3d suggested changes Apr 29, 2024
View reviewed changes
Copy link

@sidy3d sidy3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the reference to brotli.exe.

@microsoft-github-policy-service microsoft-github-policy-service bot added Changes-Requested Changes Requested Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Apr 29, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Apr 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Installation-Error Error installing application Changes-Requested Changes Requested labels Apr 29, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Apr 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 29, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335141
2024-04-29 09:20:03.118 [CLI ] Unable to locate nested installer at: C:\Users\VALIDA1\AppData\Local\Temp\WinGet\Libjxl.Libjxl.0.10.2\extracted\cjxl.exe
2024-04-29 16:19:39.700 [CLI ] Unable to locate nested installer at: C:\Users\VALIDA1\AppData\Local\Temp\WinGet\Libjxl.Libjxl.0.10.2\extracted\cjxl.exe

(Automated response - build 877.)

@Trenly
Copy link
Contributor

Trenly commented Apr 29, 2024

[Policy] Zip binary

@microsoft-github-policy-service microsoft-github-policy-service bot added zip-binary Depends on library files that aren't available via symlink Blocking-Issue Manifest validation is blocked by a known issue. labels Apr 29, 2024
@vikingnope vikingnope closed this Apr 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Apr 29, 2024
@vikingnope vikingnope deleted the Libjxl.Libjxl-0.10.2-bd6f1004-56f5-4cef-8ddb-37b154fcef88 branch May 3, 2024 20:30
@vikingnope vikingnope removed their assignment May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidy3d sidy3d sidy3d requested changes

Assignees
No one assigned
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Validation-Installation-Error Error installing application zip-binary Depends on library files that aren't available via symlink
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: libjxl
5 participants
@vikingnope @wingetbot @stephengillie @Trenly @sidy3d