Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: Xiph.Flac version 1.4.3 #151387

Closed
wants to merge 2 commits into from
Closed

New package: Xiph.Flac version 1.4.3 #151387

wants to merge 2 commits into from

Conversation

vikingnope
Copy link
Contributor

@vikingnope vikingnope commented Apr 28, 2024 •
edited by microsoft-github-policy-service bot

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Resolves: #151382

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Apr 28, 2024
sidy3d
sidy3d suggested changes Apr 29, 2024
View reviewed changes
Copy link

@sidy3d sidy3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PortableCommandAlias should be set to flac for both architectures.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 29, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-Executable-Error labels Apr 29, 2024
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Apr 29, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\flac.exe returned exit code: -1073741515
Executable C:\Users\Validator\AppData\Local\Microsoft\WinGet\Links\flac.exe returned exit code: -1073741515

(Automated response - build 877.)

@sidy3d
Copy link

sidy3d commented Apr 29, 2024

The executables require libFLAC.dll and libFLAC++.dll which are included in the archive package. I am not sure how to reference them the manifest.

@stephengillie stephengillie added the zip-binary Depends on library files that aren't available via symlink label Apr 29, 2024
@stephengillie stephengillie removed their assignment Apr 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. labels Apr 29, 2024
@vikingnope vikingnope closed this Apr 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Apr 29, 2024
@vikingnope vikingnope deleted the Xiph.Flac-1.4.3-21e27680-cd85-45bc-8f1b-373e7ce2e4d2 branch May 3, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidy3d sidy3d sidy3d requested changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. New-Package Validation-Executable-Error zip-binary Depends on library files that aren't available via symlink
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: flac
4 participants
@vikingnope @wingetbot @stephengillie @sidy3d