Rename "Turn on Sync..." to "Turn on Preferences Sync..."

[sandy081]

Turn on Sync... action to turn on syncing preferences is bit not clear and does not say what it is syncing. User will come to know only after executing that action. Instead rename it Turn on Preferences Sync... so that user already knows what this action is about.

[GustavoASC]

I'll help you guys making a PR on this 😄

[GustavoASC]

@sandy081 Some messages and labels have already been translated to different languages.

E.g.: the key "turn on sync" for nls.localize (found in userDataSync.ts) is "Ativar sincronização" in PT-BR according to this file. Should we keep the same old key "turn on sync" for nls.localize or rename this key and update all the language packs too?

[sandy081]

Do not update language packs. There is a team which will take care of this after we do the change here.

[GustavoASC]

@sandy081 Sorry if it's written somewhere but I searched and didn't find it. The option Turn on sync... doesn't appear on Code OSS Dev on File -> Preferences menu.

I tryed modifying product.json inside vscode root folder, adding:

"configurationSync.store": {
	"url": "http://localhost:3000",
	"authenticationProviderId": "MSA"
}

But even doing this the menu doesn't appear.
Is there something else to do so this menu appears on Code OSS Dev?

Debugging method registerTurnOnSyncAction() of userDataSync.ts makes me believe CONTEXT_SYNC_STATE keeps Uninitialized...

[sandy081]

Yup. Configuration store url is not public and hence I cannot provide it here. Sorry for that. Given this it is hard for users to submit PRs here. I will look into this.

[sandy081]

I would like to still have Turn on terminology as it is not one time sync, in fact it is turning on syncing preferences. Hence would like to call Turn on Preferences Sync...

[sandy081]