Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify language in git extension for creating new branch from another branch #90158

Closed
iannotian opened this issue Feb 6, 2020 · 3 comments · Fixed by #90160
Closed

Clarify language in git extension for creating new branch from another branch #90158

iannotian opened this issue Feb 6, 2020 · 3 comments · Fixed by #90160
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Milestone

Comments

@iannotian
Copy link

When using the git extension, the intent is clear when clicking on "+ Create new branch..." and immediately being prompted "Please provide a branch name".

image

image

But, when clicking on "+ Create a new branch from..." the intent is ambiguous, since the statement "Please provide a branch name" could refer to the branch from which you wish to base the new branch or the name of the new branch, the latter being what actually happens. I've gotten confused one too many times, and inadvertently typed "develop" for the first prompt, only to be prompted with "Select a ref to create the 'develop' branch from". Whoops, time to start over.

image

By specifying "Please provide a new branch name...", the intent is clear: the prompt is asking for the name you wish to call the new branch.

@joaomoreno
Copy link
Member

Let's swap the pick order, what do you think?

@joaomoreno joaomoreno added info-needed Issue requires more information from poster bug Issue identified by VS Code Team member as probable bug git GIT issues and removed info-needed Issue requires more information from poster labels Feb 7, 2020
@joaomoreno joaomoreno added this to the February 2020 milestone Feb 7, 2020
@joaomoreno
Copy link
Member

Oh I see you already have a PR for it 👍

@RMacfarlane RMacfarlane added the verified Verification succeeded label Feb 27, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants